Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActivityPub fixes for ContentType and Follow Messages #200

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ActivityPub fixes for ContentType and Follow Messages #200

wants to merge 3 commits into from

Conversation

TomCasavant
Copy link
Contributor

@TomCasavant TomCasavant commented Nov 8, 2024 •
edited
Loading

Closes #191

  • Fixed express.json to handle application/ld+json as well
  • Set headers for AP endpoints to use Content-Type application/activity+json
  • Fixed issue with Follow Message guid in AP objects (we were returning the internal guid rather than the URL path to the AP object)
  • When fetching users/user inboxes we were appending '.json' to the URL, changed it so we specify the content type of the request (because many AP servers do not accept the '.json')
  • Modified webfinger endpoint

Edit:
View of user profile from bluesky which previously couldn't be bridged:
image

View of bluesky follower which previously would be ignored:
image

@TomCasavant
Copy link
Contributor Author

Also probably fixes #124 and #185 (I have tested none of the mentioned AP servers in either of those issue) and addresses some of the concerns in #197

@ckolderup
Copy link
Owner

thanks Tom! I'll be home for like three days the middle of next week between back-to-back trips and will try to give this a look during that time.

@kvibber
Copy link

kvibber commented Dec 24, 2024 •
edited
Loading

FYI, I pulled this branch into my server's copy of the code, and now I'm able to federate both ways with GoToSocial, Snac, and Bridgy Fed (including full federation with Bluesky across the bridge), none of which worked before. (Also Akkoma, but I don't remember if that one worked before.)

Correction: It mostly works. With Postmarks following a GoToSocial user, the GTS user's posts show up as by @undefined@gts-server-name on the Network page. But it is following, and comments by GTS users display correctly on individual bookmark pages.

@TomCasavant TomCasavant mentioned this pull request Feb 2, 2025
Closed
@stefanhayden
Copy link

this also fixed the issue I was having here #201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to follow @[email protected] user
4 participants
@TomCasavant @ckolderup @kvibber @stefanhayden